Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The contract addresses of factory and paymaster can be provided (if any) #176

Closed
octavei opened this issue Jul 27, 2023 · 6 comments · Fixed by #262
Closed

The contract addresses of factory and paymaster can be provided (if any) #176

octavei opened this issue Jul 27, 2023 · 6 comments · Fixed by #262
Labels
question Further information is requested

Comments

@octavei
Copy link

octavei commented Jul 27, 2023

The contract addresses of factory and paymaster can be provided (if any). This is very beneficial for our next test, thank you

@Vid201
Copy link
Member

Vid201 commented Jul 27, 2023

Hey @octavei , I am not sure what you mean by that. There are multiple factory smart contracts and paymasters. Do you mean including some of them in README.md or bundler whitelisting certain factories and paymasters?

@octavei
Copy link
Author

octavei commented Jul 27, 2023

Hey @octavei , I am not sure what you mean by that. There are multiple factory smart contracts and paymasters. Do you mean including some of them in README.md or bundler whitelisting certain factories and paymasters?

including some of them in README.md

@zsluedem
Copy link
Collaborator

Maybe we could just put something ONLY from https://github.com/eth-infinitism/account-abstraction (or something reliable). It is sometimes risky to put an address without auditing(understanding).

@zsluedem
Copy link
Collaborator

https://www.jiffyscan.xyz/paymasters?pageNo=1&pageSize=10 Jiffyscan got some good data about paymaster and factory.

@da-bao-jian
Copy link
Contributor

da-bao-jian commented Aug 5, 2023

Hey @octavei , I am not sure what you mean by that. There are multiple factory smart contracts and paymasters. Do you mean including some of them in README.md or bundler whitelisting certain factories and paymasters?

including some of them in README.md

This is the most comprehensive list I've came across. Bundler, Paymasters, and account factories.

@Vid201 @zsluedem Should I add this to the README? Then marked the ones that have been audited

@Vid201
Copy link
Member

Vid201 commented Aug 5, 2023

Hey @octavei , I am not sure what you mean by that. There are multiple factory smart contracts and paymasters. Do you mean including some of them in README.md or bundler whitelisting certain factories and paymasters?

including some of them in README.md

This is the most comprehensive list I've came across. Bundler, Paymasters, and account factories.

@Vid201 @zsluedem Should I add this to the README? Then marked the ones that have been audited

Hmm, I am not sure about adding specific ones to the README.md (or code). I think it's fine at the moment to just add the link above to the README.md and show how to do whitelisting.

@Vid201 Vid201 added the question Further information is requested label Sep 7, 2023
@Vid201 Vid201 linked a pull request Dec 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants