Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to retrieve flags #30

Closed
jyn514 opened this issue Nov 18, 2021 · 1 comment · Fixed by #31
Closed

Make it possible to retrieve flags #30

jyn514 opened this issue Nov 18, 2021 · 1 comment · Fixed by #31

Comments

@jyn514
Copy link
Contributor

jyn514 commented Nov 18, 2021

Right now, SpanContextState::flags() is crate-private, making it impossible to retrieve the flags (e.g. for serialization to another service). It would be nice for it to be public instead; I'm having to use opentelemetry-jaeger instead in the meantime.
@sile
Copy link
Owner

sile commented Nov 20, 2021

It sounds nice.
I'll be busy for a while but I can review the PR if you (or someone) create that.

@jyn514 jyn514 mentioned this issue Nov 23, 2021
Merged
@sile sile closed this as completed in #31 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make SpanContextState::flags() public jyn514/rustracing_jaeger
2 participants
@sile @jyn514