-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[manual] Figure in section 1.3 has shoddy margins #1211
Comments
I see what you're talking about on the SILE website, yes. For me the whole manual doesn't even build, I get an error, even if I install
That being said, I hacked the file Most likely this got fixed in SILE recently? |
@NieDzejkob Thanks for this report. Unfortunately this isn't an image margin issue, it is the drop-cap / floating frame mechanism and it is absolutely cantankerous. I really wish we had this fixed, but so far I haven't come up with a magic incantation that works robustly. It can be fiddled with given the exact details of any given page, but nothing works reliably without hand tweaking for each case. (@ctrlcctrlv this is probably why yours looks okay, it is highly sensitive to the exact font metrics and content at any given moment). This is a duplicate of #860 (re the manual) but the underlying issue is actually #394. At this point I have a dozen branches with attempts to fix this (with names like @ctrlcctrlv Are you trying to build the manual with |
@alerque I didn't realize that I couldn't just run
|
Oh, that build failure is probably due to mismatched |
Using All that still doesn't explain why you can't build the manual. The manual being in working order is something we require of even merge to master via CI. See e.g. the current HEAD build, the manual is successfully building in there. I can also do it locally both with system Luarocks or vendored. Can you try a |
In section 1.3 "SILE versus InDesign", the figure is outright touching the baseline of the text above it, and obscuring descenders of letters like
g
. This is hideously ugly. It feels petty to say outloud, but when I saw this, my interest in learning about SILE quickly wavered...The text was updated successfully, but these errors were encountered: