Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test benchmarks #2

Closed
wants to merge 1 commit into from
Closed

Test benchmarks #2

wants to merge 1 commit into from

Conversation

siku2
Copy link
Owner

@siku2 siku2 commented Jun 9, 2020

Description

Fixes # (issue)

Checklist:

  • I have ran ./ci/run_stable_checks.sh
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works

Repository owner deleted a comment from github-actions bot Jun 9, 2020
@github-actions
Copy link

github-actions bot commented Jun 9, 2020

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of yew-baseline (typically latest master)
  • update: performance of yew (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
+ 01_run1k               |       163.22 |   318.82 |  310.14 |   -2.72%
+ 02_replace1k           |       176.39 |   344.64 |  327.17 |   -5.07%
+ 03_update10th1k_x16    |       226.78 |  1264.56 |  696.10 |  -44.95%
+ 04_select1k            |        34.65 |  1084.25 |  475.02 |  -56.19%
- 05_swap1k              |        81.77 |   311.02 |  880.55 | +183.12%
- 06_remove-one-1k       |        36.80 |    90.96 |  204.24 | +124.54%
- 07_create10k           |      1659.47 |  5603.50 | 6065.48 |   +8.24%
+ 08_create1k-after1k_x2 |       361.09 |   942.37 |  854.96 |   -9.28%
- 09_clear1k_x8          |       254.64 |   609.71 |  703.53 |  +15.39%
+ 21_ready-memory        |         1.08 |     1.07 |    1.07 |   -0.07%
- 22_run-memory          |         1.57 |     2.14 |    2.14 |   +0.06%
+ 23_update5-memory      |         1.89 |     2.14 |    2.12 |   -1.26%
- 24_run5-memory         |         2.19 |     2.62 |    2.63 |   +0.07%
- 25_run-clear-memory    |         2.33 |     2.40 |    2.40 |   +0.04%
- 31_startup-ci          |      1294.58 |  1265.10 | 1279.70 |   +1.15%
+ 32_startup-bt          |        16.00 |    51.00 |   42.17 |  -17.31%
+ 34_startup-totalbytes  |        59.86 |   103.25 |   83.73 |  -18.90%

Workflow: 129938857
Adding new commits will generate a new report

@siku2
Copy link
Owner Author

siku2 commented Jun 9, 2020

Re-adding the performance label will cause a new report to be generated.

@github-actions
Copy link

github-actions bot commented Jun 9, 2020

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of yew-baseline (typically latest master)
  • update: performance of yew (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
+ 01_run1k               |       146.69 |   276.18 |  274.84 |   -0.48%
+ 02_replace1k           |       159.79 |   290.47 |  278.73 |   -4.04%
+ 03_update10th1k_x16    |       225.51 |  1136.13 |  620.53 |  -45.38%
+ 04_select1k            |        33.54 |   918.93 |  469.49 |  -48.91%
- 05_swap1k              |        75.56 |   300.20 |  761.12 | +153.53%
- 06_remove-one-1k       |        33.39 |    86.20 |  187.49 | +117.51%
- 07_create10k           |      1457.86 |  5196.30 | 5706.15 |   +9.81%
+ 08_create1k-after1k_x2 |       326.17 |   789.71 |  760.97 |   -3.64%
- 09_clear1k_x8          |       212.75 |   515.37 |  516.37 |   +0.19%
+ 21_ready-memory        |         1.08 |     1.07 |    1.07 |   -0.07%
- 22_run-memory          |         1.57 |     2.14 |    2.14 |   +0.06%
+ 23_update5-memory      |         1.89 |     2.14 |    2.12 |   -1.24%
- 24_run5-memory         |         2.19 |     2.62 |    2.63 |   +0.06%
- 25_run-clear-memory    |         2.33 |     2.40 |    2.40 |   +0.05%
+ 31_startup-ci          |      1369.63 |  1351.50 | 1322.85 |   -2.12%
- 32_startup-bt          |        18.82 |    50.20 |   50.78 |   +1.14%
+ 34_startup-totalbytes  |        59.86 |   103.25 |   83.73 |  -18.90%

Workflow: 129999095
Use /benchmark to trigger the benchmark manually

@siku2
Copy link
Owner Author

siku2 commented Jun 9, 2020

Started a benchmark for this pull request.
This comment will be updated with the results.

Workflow: 129999095
Adding new commits will generate a new report

This is the message that is shown while the benchmark is running.

@siku2
Copy link
Owner Author

siku2 commented Jun 9, 2020

Also, like the message says, adding new commits with the performance label will cause the benchmark to run again.
The following commit deliberately breaks the benchmark to demonstrate the error message:

Repository owner deleted a comment from github-actions bot Jun 9, 2020
Repository owner deleted a comment from github-actions bot Jun 9, 2020
Repository owner deleted a comment from github-actions bot Jun 9, 2020
@github-actions
Copy link

github-actions bot commented Jun 9, 2020

The benchmark failed to complete.
Please see the workflow for more details.

Workflow: 130085630
Adding new commits will generate a new report

@siku2 siku2 force-pushed the benchmark branch 3 times, most recently from 335b3fc to 9605c74 Compare June 9, 2020 18:06
@siku2 siku2 closed this Jun 9, 2020
@siku2 siku2 deleted the benchmark-test branch June 9, 2020 18:10
@siku2 siku2 removed the performance label Jun 10, 2020
siku2 pushed a commit that referenced this pull request Jul 11, 2020
Minor typo in `components.md`: 'durring' -> 'during'. Hope this isn't seen as me being nitpicky, just wanted to help :)
siku2 added a commit that referenced this pull request Nov 21, 2020
* First draft

* Fix minor typo

* Add to sidebars.json

* Fix formatting

* Update docs/concepts/components/children.md

on -> of

Co-authored-by: Teymour Aldridge <[email protected]>

* Update docs/concepts/components/children.md

Typo fix

Co-authored-by: Teymour Aldridge <[email protected]>

* Update docs/concepts/components/children.md

Reword

Co-authored-by: Teymour Aldridge <[email protected]>

* Update docs/concepts/components/children.md

Something else => an alternative method

Co-authored-by: Teymour Aldridge <[email protected]>

* Update docs/concepts/components/children.md

Rewording

Co-authored-by: Teymour Aldridge <[email protected]>

* Update docs/concepts/components/children.md

Capitialization fix

Co-authored-by: Teymour Aldridge <[email protected]>

* Fix indentation in sidebars.json

* First draft of explination

* Add suggestion

* Quick fixes from review

Co-authored-by: Simon <[email protected]>

* Quick fixes from review #2

Co-authored-by: Simon <[email protected]>

* Link to the derive_more crate

* Switch from tabs to spaces in examples.

* Inline explination as comments

* Add back accidentally deleted line

* Update examples :)

* Appease rustfmt

* Remove semi-inacurate/confusing section

Co-authored-by: Teymour Aldridge <[email protected]>
Co-authored-by: Simon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant