Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: TypeScript - Make LabelValues strict by generic label names #291

Closed
kobiburnley opened this issue Oct 7, 2019 · 1 comment
Closed

Suggestion: TypeScript - Make LabelValues strict by generic label names #291

kobiburnley opened this issue Oct 7, 2019 · 1 comment

Comments

@kobiburnley
Copy link
Contributor

In my projects I recognize the need for strict type checking on the object passed as 'labelValues', to avoid passing labels that were not declared in the metric constructor.

The idea can be seen here: https://github.com/siimon/prom-client/compare/master...kobiburnley:typescript-strict-labelValues?expand=1

(Such change might probably break existing TypeScript code-bases using prom-client)

Is it something that should be fixed?
@kobiburnley
Copy link
Contributor Author

fixed #299

@willsoto willsoto mentioned this issue Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kobiburnley