Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2023-0055: Multiple soundness issues #367

Open
github-actions bot opened this issue May 25, 2024 · 3 comments
Open

RUSTSEC-2023-0055: Multiple soundness issues #367

github-actions bot opened this issue May 25, 2024 · 3 comments

Comments

@github-actions
Copy link

Multiple soundness issues

Details
Status unsound
Package lexical
Version 6.1.1
URL
Date 2023-09-03

lexical contains multiple soundness issues:

  1. Bytes::read() allows creating instances of types with invalid bit patterns
  2. BytesIter::read() advances iterators out of bounds
  3. The BytesIter trait has safety invariants but is public and not marked unsafe
  4. write_float() calls MaybeUninit::assume_init() on uninitialized data, which is is not allowed by the Rust abstract machine

The crate also has some correctness issues and appears to be unmaintained.

Alternatives

For quickly parsing floating-point numbers third-party crates are no longer needed. A fast float parsing algorith by the author of lexical has been merged into libcore.

For quickly parsing integers, consider atoi and btoi crates (100% safe code). atoi_radix10 provides even faster parsing, but only with -C target-cpu=native, and at the cost of some unsafe.

For formatting integers in a #[no_std] context consider the numtoa crate.

For working with big numbers consider num-bigint and num-traits.

See advisory page for additional details.

@tannaurus
Copy link
Contributor

tannaurus commented Sep 17, 2024

This appears to have silenced in main https://github.com/sigstore/sigstore-rs/pull/387/files

This that a temporary solution, do we plan on monitoring this further?

A new warning has taken its place: https://rustsec.org/advisories/RUSTSEC-2023-0086

@flavio
Copy link
Member

flavio commented Sep 18, 2024

I've created timothee-haudebourg/json-number#6 that addresses both issues.

@flavio
Copy link
Member

flavio commented Oct 24, 2024

The upstream maintainer hasn't provided any feedback to the PR. There's also another PR that was created with the same purpose. No updates 😢

I've also sent a mail to the maintainer, but I didn't get any response.

I wonder how we should proceed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants