Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some initialization/flag parsing in rekor-server. #433

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

dlorenc
Copy link
Member

@dlorenc dlorenc commented Sep 14, 2021

This is in preparation for supporting multiple logIDs (for sharding).

Signed-off-by: Dan Lorenc [email protected]

@dlorenc
Copy link
Member Author

dlorenc commented Sep 14, 2021

Up next:

  • support starting the server with multiple log IDs, instead of just one.
    • this will probably look like a config file containing a map of index ranges to log ids.
    • only one can be "active"
  • support parsing the UUID during GET calls to determine which log to query (with defaulting for the 0 case here)

This is in preparation for supporting multiple logIDs (for sharding).

Signed-off-by: Dan Lorenc <[email protected]>
@cpanato cpanato requested a review from bobcallaway September 14, 2021 07:50
@cpanato cpanato added this to the v1.0.0 milestone Sep 14, 2021
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlorenc dlorenc merged commit d089e5d into sigstore:main Sep 14, 2021
@dlorenc dlorenc deleted the cleanup branch September 14, 2021 11:29
@dlorenc dlorenc mentioned this pull request Sep 14, 2021
4 tasks
@lkatalin lkatalin mentioned this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants