Port flag is ignored

[lukehinds]

Port flag is ignored.

go run cmd/server/main.go serve --port 6962 
2021-03-25T09:25:34.084Z	INFO	app/root.go:100	Using config file: /root/rekor/rekor-server.yaml
2021-03-25T09:25:34.093Z	INFO	app/serve.go:70	Loading support for pluggable type 'rekord'
2021-03-25T09:25:34.093Z	INFO	app/serve.go:71	Loading version '0.0.1' for pluggable type 'rekord'
2021-03-25T09:25:34.093Z	INFO	app/serve.go:70	Loading support for pluggable type 'rpm'
2021-03-25T09:25:34.093Z	INFO	app/serve.go:71	Loading version '0.0.1' for pluggable type 'rpm'
2021-03-25T09:25:34.105Z	INFO	restapi/server.go:231	Serving rekor server at http://127.0.0.1:3000

[lukehinds]

same appears to be the case for host

go run cmd/server/main.go serve --host a.b.c.d 
2021-03-25T09:38:58.030Z	INFO	app/root.go:100	Using config file: /root/rekor/rekor-server.yaml
2021-03-25T09:38:58.039Z	INFO	app/serve.go:70	Loading support for pluggable type 'rekord'
2021-03-25T09:38:58.039Z	INFO	app/serve.go:71	Loading version '0.0.1' for pluggable type 'rekord'
2021-03-25T09:38:58.039Z	INFO	app/serve.go:70	Loading support for pluggable type 'rpm'
2021-03-25T09:38:58.039Z	INFO	app/serve.go:71	Loading version '0.0.1' for pluggable type 'rpm'
2021-03-25T09:38:58.051Z	INFO	restapi/server.go:231	Serving rekor server at http://127.0.0.1:3000

[puerco]

Just to get familiar with the codebase, as looking into this issue over the weekend but I was wondering if #339 will supersede it. WDYT @bobcallaway ?

[bobcallaway]

Just to get familiar with the codebase, as looking into this issue over the weekend but I was wondering if #339 will supersede it. WDYT @bobcallaway ?

no, I don't think it will supersede it. I think the issue here is that we have two command line args for port and one is stomping over the other:

rekor/cmd/rekor-server/app/serve.go

Line 96 in 1c30d2f

server.Port = int(viper.GetUint("rekor_server.port"))

overwrites the value of the arg --port with the value of --rekor_server.port

[hectorj2f]

I created a PR to handle this issue here #396 :).