Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and starting to warn when folks use the short-name version of the predicate type? #609

Closed
vaikas opened this issue Feb 23, 2023 · 2 comments · Fixed by #610
Closed

Deprecate and starting to warn when folks use the short-name version of the predicate type? #609

vaikas opened this issue Feb 23, 2023 · 2 comments · Fixed by #610
Assignees
@vaikas

Comments

@vaikas
Copy link
Collaborator

vaikas commented Feb 23, 2023

I'd love it if we could get folks using explicit predicate types, since the short names have been so fraught.

Thanks for bumping this @hectorj2f 👍

Originally posted by @mattmoor in #602 (comment)
@vaikas
Copy link
Collaborator Author

vaikas commented Feb 23, 2023

Also touches #608

@vaikas vaikas self-assigned this Feb 23, 2023
@vaikas
Copy link
Collaborator Author

vaikas commented Feb 23, 2023

I'm going to make the following changes:

  • values using the short-name will get a deprecation warning
  • values using non RFC3986 compliant predicates will get a deprecation warning

@vaikas vaikas mentioned this issue Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaikas vaikas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate short-names, and warn on non RFC3986 compliant predicate-types vaikas/policy-controller
1 participant
@vaikas