Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a CLI #330

Open
di opened this issue Nov 22, 2024 · 0 comments
Open

Provide a CLI #330

di opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@di
Copy link
Member

di commented Nov 22, 2024

What's missing

Right now the https://pypi.org/project/model-signing/ project does not provide a single CLI entrypoint for this library, instead just providing an importable API. The source repo provides sign.py and verify.py scripts, but these are not included in published distributions, and must be used directly from source checkout.

Additionally, the library itself is not executable after install:

$ python -m pip install model_signing
...

$ python -m model_signing
/usr/local/bin/python: No module named model_signing.__main__; 'model_signing' is a package and cannot be directly executed

What I'd like to see

Ideally, upon install, the library provides a CLI with similar functionality to the sign.py and verify.py scripts, e.g.:

$ python -m pip install model_signing
...

$ python -m model_signing --help
usage: model_signing [-h] [-v] [-V] COMMAND ...
model_signing: error: the following arguments are required: COMMAND

$ python -m model_signing sign --help
usage: Script to sign models [-h] --model_path MODEL_PATH [--sig_out SIG_OUT] {pki,private-key,sigstore,skip} ...
Script to sign models: error: the following arguments are required: --model_path, method

$ python -m model_signing verify --help
usage: Script to verify models [-h] --sig_path SIG_PATH [--model_path MODEL_PATH] {pki,private-key,sigstore,skip} ...
Script to verify models: error: the following arguments are required: --sig_path, method

Related
#328 and #329 are related

@di di added the enhancement New feature or request label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant