Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make python typing and linting errors be displayed in the PR review tab #289

Open
mihaimaruseac opened this issue Aug 15, 2024 · 4 comments
Open

Make python typing and linting errors be displayed in the PR review tab #289

mihaimaruseac opened this issue Aug 15, 2024 · 4 comments
Labels
area:ci enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mihaimaruseac
Copy link
Collaborator

Right now, if python linting/type checking fails, we need to go to the report in the workflow.

It would be ideal to have github formatted output showing up to files in the PRs on the lines that are not ok.
@mihaimaruseac mihaimaruseac added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed area:ci labels Aug 15, 2024
@rakshitgondwal
Copy link

Hey @mihaimaruseac, I'd like to pick this up

@mihaimaruseac
Copy link
Collaborator Author

We don't block issues on who declares to work on them, we just look at the PRs. Please feel free to work on it and I'm looking forward to the PR. Thank you

@alexecse
Copy link

Hello @mihaimaruseac. I would like to work on this issue!

@mihaimaruseac
Copy link
Collaborator Author

Awesome. Please see #293 and #295 as starting points, as those were made to make the test coverage visible in the PR review, something very similar to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:ci enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mihaimaruseac @alexecse @rakshitgondwal