Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitsign env test #568

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix gitsign env test #568

merged 1 commit into from
Oct 10, 2024

Conversation

adityasaky
Copy link
Member

Summary

The env test fails if the testing environment has other sigstore / gitsign related env vars set. This commit unsets them for the duration of the test.

Recent CI jobs have failed because github actions now has a SIGSTORE_ID_TOKEN variable set

Release Note

NONE

Documentation

NONE

The env test fails if the testing environment has other sigstore / gitsign
related env vars set. This commit unsets them for the duration of the test.

Signed-off-by: Aditya Sirish A Yelgundhalli <[email protected]>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks

@cpanato cpanato merged commit 6619f72 into sigstore:main Oct 10, 2024
7 checks passed
@adityasaky adityasaky deleted the fix-env-test branch October 10, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants