Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Client Secret File #533

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

sabre1041
Copy link
Contributor

Summary

Added support for specifying the file containing the OIDC client secret. Resolves #365

Release Note

  • Support for specifying a file containing the OIDC client secret

@@ -57,6 +58,9 @@ type Config struct {

// OIDC client ID for application
ClientID string
// File containing the OIDC Client Secret
clientSecretFile string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clientSecretFile string
ClientSecretFile string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato Emulating the design in cosign.

Testing issues resolved and checks are ✅

@sabre1041 sabre1041 force-pushed the client-secret-file branch from abe9737 to dc68692 Compare June 28, 2024 13:31
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cpanato cpanato requested a review from wlynch June 28, 2024 13:43
@wlynch
Copy link
Member

wlynch commented Jun 28, 2024

Thanks @sabre1041!

@wlynch wlynch merged commit 6431500 into sigstore:main Jun 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for oidc client secret config
3 participants