Fix offline verification marshalling, add e2e tests. #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlynch
force-pushed
the
offline-verify-test
branch
from
3f50bae to
2a401d3
Compare
e2e verification was failing because we were using the wrong body to recreate the tlog message. To test this, this also adds an e2e test that verifies a real commit only using offline verification. This is a bit brittle at the moment because it will mutate the local TUF client state, but this will hopefully be improved once the TUF client changes land in sigstore/client-go. Signed-off-by: Billy Lynch <[email protected]>
wlynch
force-pushed
the
offline-verify-test
branch
from
2a401d3 to
d7d9473
Compare
priyawadhwa
approved these changes
Jun 5, 2023
cpanato
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
e2e verification was failing because we were using the wrong body to recreate the tlog message.
To test this, this also adds an e2e test that verifies a real commit only using offline verification. This is a bit brittle at the moment because it will mutate the local TUF client state, but this will hopefully be improved once the TUF client changes land in sigstore/client-go.
Because of how we're using the Search API, this didn't surface immediately since the Search fallback still picked up the certificate used to sign.
Part of #219
Release Note
Used correct body foroffline verification.
Documentation