Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create certificate specification #703

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

haydentherapper
Copy link
Contributor

This outlines what MUST and SHOULD and MAY and SHOULD NOT
and MUST NOT be included with CA and end-entity certificates.

Fixes #698

Signed-off-by: Hayden Blauzvern [email protected]

Summary

Release Note

Documentation

@haydentherapper
Copy link
Contributor Author

haydentherapper commented Jul 22, 2022

cc @woodruffw @znewman01

This outlines what MUST and SHOULD and MAY and SHOULD NOT
and MUST NOT be included with CA and end-entity certificates.

Signed-off-by: Hayden Blauzvern <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #703 (2ae4012) into main (d9fe79b) will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   54.00%   54.35%   +0.35%     
==========================================
  Files          36       36              
  Lines        2248     2248              
==========================================
+ Hits         1214     1222       +8     
+ Misses        940      934       -6     
+ Partials       94       92       -2     
Impacted Files Coverage Δ
pkg/ca/fileca/load.go 68.96% <0.00%> (+10.34%) ⬆️
pkg/ca/fileca/watch.go 100.00% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Hayden Blauzvern <[email protected]>
znewman01
znewman01 previously approved these changes Aug 3, 2022
Copy link
Contributor

@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I echo @woodruffw's comments but otherwise LGTM

@haydentherapper
Copy link
Contributor Author

Thanks y’all! Sorry, will circle back to finishing this later this week.

Signed-off-by: Hayden Blauzvern <[email protected]>
@haydentherapper haydentherapper merged commit dcdf60c into sigstore:main Aug 5, 2022
@haydentherapper haydentherapper deleted the certificate-spec branch August 5, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a specification for issued certificates
6 participants