Correct the type used for attest #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Moore <[email protected]>
cpanato
previously approved these changes
Aug 4, 2022
vaikas
previously approved these changes
Aug 4, 2022
priyawadhwa
previously approved these changes
Aug 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #2128 +/- ##
=======================================
Coverage 26.28% 26.28%
=======================================
Files 130 130
Lines 7602 7602
=======================================
Hits 1998 1998
Misses 5347 5347
Partials 257 257 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Matt Moore <[email protected]>
mattmoor
dismissed stale reviews from priyawadhwa, vaikas, and cpanato
via
7d7fbd2
priyawadhwa
approved these changes
Aug 4, 2022
cpanato
approved these changes
Aug 4, 2022
bradbeck
added a commit
to buildsec/frsca
that referenced
this pull request
Sep 8, 2022
Specify the type when using `cosign verify-attestation …`. This is to defend against a change in default behavior related to sigstore/cosign#2128 Signed-off-by: Brad Beck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the e2e testing at head, which wasn't caught by the GHSA private fork, which doesn't run e2e testing.
Make the predicate type we attest match what we verify!
Signed-off-by: Matt Moore [email protected]
Release Note
Documentation