Add ability to inline secrets from SecretRef to configmap. #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
+ Coverage 27.44% 27.86% +0.42%
==========================================
Files 137 137
Lines 7742 7783 +41
==========================================
+ Hits 2125 2169 +44
+ Misses 5387 5385 -2
+ Partials 230 229 -1
Continue to review full report at Codecov.
|
Use tracker to keep track of changes to secrets, for example if a secret doesn't exist initially, once it shows up. Tested obvs with UT but also tested on a real cluster that the tracker is keeping track of changes to secrets. Fix sigstore#1573 Signed-off-by: Ville Aikas <[email protected]>
|
I don't quite understand why the codecov is changing for this 'untouched' file: |
hectorj2f
reviewed
Mar 11, 2022
| if len(secret.Data) == 0 { | ||
| return fmt.Errorf("secret %q contains no data", keyref.SecretRef.Name) | ||
| } | ||
| if len(secret.Data) > 1 { |
There was a problem hiding this comment.
what about validating that the data field contains a publicKey field like here https://github.com/sigstore/cosign/pull/1595/files#diff-f95503af2405ad769f56a5e3ec662f2d57380441e636ba81ffe33b93e00ea4ebR437 ?
There was a problem hiding this comment.
I'll do that in a followup?
#1596
hectorj2f
approved these changes
Mar 11, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…1595) Use tracker to keep track of changes to secrets, for example if a secret doesn't exist initially, once it shows up. Tested obvs with UT but also tested on a real cluster that the tracker is keeping track of changes to secrets. Fix sigstore#1573 Signed-off-by: Ville Aikas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use tracker to keep track of changes to secrets, for example
if a secret doesn't exist initially, once it shows up. Tested
obvs with UT but also tested on a real cluster that the tracker
is keeping track of changes to secrets.
Fix #1573
Signed-off-by: Ville Aikas [email protected]
Summary
Ticket Link
Fixes
Release Note