Mirror signed release images from GCR to GHCR as part of release with… #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1547 +/- ##
=======================================
Coverage 26.49% 26.49%
=======================================
Files 126 126
Lines 7214 7214
=======================================
Hits 1911 1911
Misses 5093 5093
Partials 210 210 Continue to review full report at Codecov.
|
cpanato
reviewed
Mar 4, 2022
|
|
||
| .PHONY: copy-cosign-signed-release-to-ghcr | ||
| copy-cosign-signed-release-to-ghcr: | ||
| cosign copy $(KO_PREFIX)/cosign:$(GIT_VERSION) $(GHCR_PREFIX)/cosign:$(GIT_VERSION) |
There was a problem hiding this comment.
right now we are pushing the ci images to the following paths:
ghcr.io/sigstore/cosign/cosignfor cosignghcr.io/sigstore/cosign/cosignedfor cosignedghcr.io/sigstore/cosign/sgetfor sget
I think for now we might keeping push to those paths
I've copy the gcr image of v.1.6.0 today to the ghcr.io/sigstore/cosign/cosign
$ COSIGN_EXPERIMENTAL=1 cosign verify ghcr.io/sigstore/cosign/cosign:v1.6.0
Verification for ghcr.io/sigstore/cosign/cosign:v1.6.0 --
The following checks were performed on each of these signatures:
- The cosign claims were validated
- Existence of the claims in the transparency log was verified offline
- Any certificates were verified against the Fulcio roots.
[{"critical":{"identity":{"docker-reference":"gcr.io/projectsigstore/cosign"},"image":{"docker-manifest-digest":"sha256:b667002156c4bf9fedd9273f689b800bb5c341660e710e3bbac981c9795423d9"},"type":"cosign container image signature"},"optional":{"Bundle":{"SignedEntryTimestamp":"MEUCIQDKOjHLFQDrOfI0FGxaOUVcrvuh639SwV+4rhim2cg3ZAIgctpg49VMRpvKJ5ENfLuma6vcfaoxaWa6i8GaRhF/HLo=","Payload":{"body":"eyJhcGlWZXJzaW9uIjoiMC4wLjEiLCJraW5kIjoiaGFzaGVkcmVrb3JkIiwic3BlYyI6eyJkYXRhIjp7Imhhc2giOnsiYWxnb3JpdGhtIjoic2hhMjU2IiwidmFsdWUiOiI2ZDI3N2QyMWNlNDJmODgzNjM0ZGYyMTM5MzhjNGUxOGYzNTI0N2I5OGZiYmZlY2ExNzY1MWE1MjQ1MjIxYmEwIn19LCJzaWduYXR1cmUiOnsiY29udGVudCI6Ik1FVUNJUUNMOEJFKzdmeWJyNjZDK1RlNEs4NTBoNEFmb2dEand3WkhFaEtYQjkyL3RRSWdjS0luQkVkWHFoWHBYeDJWRFVjZmxwOUMxdlFrQXUwZHRIczdadEYzd213PSIsInB1YmxpY0tleSI6eyJjb250ZW50IjoiTFMwdExTMUNSVWRKVGlCRFJWSlVTVVpKUTBGVVJTMHRMUzB0Q2sxSlNVTk1WRU5EUVdKTFowRjNTVUpCWjBsVVkwdDNURWxSTUVGdGVISlZTRlZtVkhKaWJDOW9aM05YZEdwQlMwSm5aM0ZvYTJwUFVGRlJSRUY2UVhFS1RWSlZkMFYzV1VSV1VWRkxSWGQ0ZW1GWFpIcGtSemw1V2xNMWExcFlXWGhGVkVGUVFtZE9Wa0pCVFZSRFNFNXdXak5PTUdJelNteE5RalJZUkZSSmVRcE5SRTEzVGtSQk5FMVVTVEJQVm05WVJGUkplVTFFVFhkT1JFRTBUV3BKTUU5R2IzZEJSRUphVFVKTlIwSjVjVWRUVFRRNVFXZEZSME5EY1VkVFRUUTVDa0YzUlVoQk1FbEJRa2huVDBsSmJGUkRMMUpQUW1kVFNtbG9VMkZxYlRoVGNrdGtSRmcyYXk5a2VXZzFVMHRoYTNCWlVUSkxUR0ZUZFd3eGRrSTFMeThLVEVkVk1pOUlTM0JtZFV4VWRqZ3ZUaXRCTTI1R1lrVmhTakp1YlRGaFpXcG5aVUYzWjJRd2QwUm5XVVJXVWpCUVFWRklMMEpCVVVSQloyVkJUVUpOUndwQk1WVmtTbEZSVFUxQmIwZERRM05IUVZGVlJrSjNUVVJOUVhkSFFURlZaRVYzUlVJdmQxRkRUVUZCZDBoUldVUldVakJQUWtKWlJVWkNZVE5XTTBOb0NrWkZZbk01V214SVowNTBhRlUwV1ZVeVlrUjBUVUk0UjBFeFZXUkpkMUZaVFVKaFFVWkdha0ZJYkN0U1VtRldiWEZZY2sxclMwZFVTWFJCY1hoaldEWUtUVVF3UjBFeFZXUkZVVVZDTDNkUmVrMUVSMEpNTW5Sc1pWZDRiR016VGtGalNFcDJZVzFXYW1SSVRuQmFNMDR3WWpOS2JFeHRiR2hpVXpWdVl6SldlUXBrYld4cVdsZEdhbGt5T1RGaWJsRjFXVEk1ZEUxRGEwZERhWE5IUVZGUlFtYzNPSGRCVVVWRlJ6Sm9NR1JJUW5wUGFUaDJXVmRPYW1JelZuVmtTRTExQ2xveU9YWmFNbmhzVEcxT2RtSlVRVXRDWjJkeGFHdHFUMUJSVVVSQmQwNXdRVVJDYlVGcVJVRnROV013UWtSYVdVOXpNMDByZGxRd01DdDFXbEJXZDJnS1RHNXdORXB5TWs0dmFXTnpPV0ZLWXk5UFNrb3ZRa1JIWTIwMVMzRnFTVkYzZDFVeVR6UnBaRUZxUlVFNU9FeHlXR3RhUlhoaE1UWlFSM2t6VGxOVlJBcEZkakZpVUhGNU5tbzBaRkZCUzBzM1dXOVlXRlpNY0hkbU16SjBaSE5aWW14aFFYQnlVakZ0Y2sxTGJ3b3RMUzB0TFVWT1JDQkRSVkpVU1VaSlEwRlVSUzB0TFMwdENnPT0ifX19fQ==","integratedTime":1646381571,"logIndex":1556936,"logID":"c0d23d6ad406973f9559f3ba2d1ca01f84147d8ffc5b8445c224f98b9591801d"}},"GIT_HASH":"4b2c3c0c8ee97f31b9dac3859b40e0a48b8648ee","GIT_VERSION":"v1.6.0","Issuer":"https://accounts.google.com","Subject":"[email protected]"}}]
There was a problem hiding this comment.
thanks for pointing out the current ghcr prefix.
changed it to ghcr.io/sigstore/cosign, to match the current behavior.
is this what we want for the other repos as well, ghcr.io/sigstore/fulcio/fulcio and ghcr.io/sigstore/rekor/rekor ?
There was a problem hiding this comment.
for fulcio we can keep ghcr.io/sigstore/fulcio
but for rekor we might do the similar from cosign because we have both rekor-server and cli
ghcr.io/sigstore/rekor/rekor-server
ghcr.io/sigstore/rekor/rekor-cli
… Cloud Build. Signed-off-by: Kenny Leung <[email protected]>
cpanato
approved these changes
Mar 4, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
… Cloud Build. (sigstore#1547) Signed-off-by: Kenny Leung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Cloud Build.
Signed-off-by: Kenny Leung [email protected]
Summary
Copy signed released image from GCR to GHCR using cosign cli copy command.
This will ensure the signature will be the same between the two registry.
This keep consistent with Fulcio, sigstore/fulcio#421, to publish to GCR and GHCR.
@cpanato
Ticket Link
Fixes
Release Note