Fix double time import in e2e tests
#1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just saw this little nit while fixing the e2e tests in another PR. I think we can also avoid the time conversions because we already pass the correct type to the functions. Signed-off-by: Sascha Grunert <[email protected]>
cpanato
approved these changes
Feb 2, 2022
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
Just saw this little nit while fixing the e2e tests in another PR. I think we can also avoid the time conversions because we already pass the correct type to the functions. Signed-off-by: Sascha Grunert <[email protected]>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Just saw this little nit while fixing the e2e tests in another PR. I think we can also avoid the time conversions because we already pass the correct type to the functions. Signed-off-by: Sascha Grunert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just saw this little nit while fixing the e2e tests in another PR. I
think we can also avoid the time conversions because we already pass the
correct type to the functions.
Ticket Link
None
Release Note