Export function to verify individual signature #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling the existing VerifyImageSignatures function multiple times for the same image with different verifiers will download the OCI manifest multiple times. This is inefficient and slow. Exporting a function that verifies a single signature allows the decoupling of the OCI manifest fetch and verification stages. Signed-off-by: Rob Best <[email protected]>
|
I don't think the test failure is related to the changes in the PR: |
|
Seems reasonable to me! Any objections to the new public API anyone? |
|
OK then, merging! |
dlorenc
approved these changes
Jan 18, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Calling the existing VerifyImageSignatures function multiple times for the same image with different verifiers will download the OCI manifest multiple times. This is inefficient and slow. Exporting a function that verifies a single signature allows the decoupling of the OCI manifest fetch and verification stages. Signed-off-by: Rob Best <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Calling the existing
VerifyImageSignaturesfunction multiple times for the same image with different verifiers will download the OCI manifest multiple times. This is inefficient and slow.Exporting a function that verifies a single signature allows the decoupling of the fetch and verification stages.
Release Note