Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gcp setup for the GH action #1330

Merged
merged 1 commit into from
Jan 16, 2022
Merged

update gcp setup for the GH action #1330

merged 1 commit into from
Jan 16, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jan 16, 2022

Summary

  • update gcp setup for the GH action
    doing this because the current way is deprecated
Warning: "service_account_key" has been deprecated. Please switch to using google-github-actions/auth which supports both Workload Identity Federation and Service Account Key JSON authentication. For more details, see https://github.com/google-github-actions/setup-gcloud#authorization

Not sure if the service_account name is correct

Ticket Link

n/a

Release Note

NONE

@dlorenc
Copy link
Member

dlorenc commented Jan 16, 2022

Not sure if the service_account name is correct

Looks correct to me!

bobcallaway
bobcallaway approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

@dlorenc dlorenc merged commit fbf8dcb into sigstore:main Jan 16, 2022
@github-actions github-actions bot added this to the v1.5.0 milestone Jan 16, 2022
@cpanato cpanato deleted the updatesh branch January 17, 2022 08:13
@cpanato cpanato mentioned this pull request Jan 17, 2022
Merged
@bobcallaway bobcallaway mentioned this pull request Jan 17, 2022
Closed
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
@cpanato @mlieberman85
update gcp setup for the GH action (sigstore#1330)
f2b0016 
Signed-off-by: Carlos Panato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorj2f hectorj2f hectorj2f approved these changes

@bobcallaway bobcallaway bobcallaway approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cpanato @dlorenc @bobcallaway @hectorj2f