Fix semantic bug in DSSE specification. #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'payloadType' field in a DSSE envelope is always supposed to be set to the in-toto media type. We were incorrectly placing the inner predicateType here. The DSSE library probably shouldn't even expose this as a parameter given that it's a MUST in the spec. Signed-off-by: Dan Lorenc <[email protected]>
|
cc @mlieberman85 for a second instance of that bug we found earlier :) |
|
The spec itself is here: https://github.com/in-toto/attestation/tree/main/spec#envelope |
loosebazooka
approved these changes
Dec 24, 2021
yeah that's weird |
|
NVM I got the layering wrong - the DSSE implementation is fine. In DSS, you can set any payloadType: https://github.com/secure-systems-lab/dsse/blob/master/protocol.md The In-ToTo Attestation Spec is the one that requires that payloadType: https://github.com/in-toto/attestation/tree/main/spec#envelope So fixing it here makes sense, given it's a library for generating in-toto attestations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'payloadType' field in a DSSE envelope is always supposed to be set
to the in-toto media type. We were incorrectly placing the inner predicateType
here.
The DSSE library probably shouldn't even expose this as a parameter given that it's
a MUST in the spec.
Signed-off-by: Dan Lorenc [email protected]
Summary
Ticket Link
Fixes
Release Note