Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for custom Annotations is missing #1773

Open
asraa opened this issue Apr 18, 2022 · 4 comments
Open

Support for custom Annotations is missing #1773

asraa opened this issue Apr 18, 2022 · 4 comments
Assignees
@developer-guy
Labels
bug Something isn't working

Comments

@asraa
Copy link
Contributor

asraa commented Apr 18, 2022

Description

It seems like verify-attestation allows you to check for annotation key pairs, but does not recognize the flag. It also is not "verified" content FWIW. Also, attest does not expose an annotation map option either, but also labels it in the help string.

@wlynch also a good starter issue maybe?
@asraa asraa added the bug Something isn't working label Apr 18, 2022
@developer-guy
Copy link
Member

may I do that @asraa ?

@developer-guy
Copy link
Member

kindly ping 🙋🏻‍♂️

@dlorenc
Copy link
Member

dlorenc commented May 19, 2022

Go for it!

@developer-guy developer-guy self-assigned this May 19, 2022
@asraa
Copy link
Contributor Author

asraa commented May 19, 2022

Ah sure! Sorry I was OOO until I got the ping :)

@developer-guy developer-guy mentioned this issue May 30, 2022
Closed
@chaospuppy chaospuppy mentioned this issue Nov 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@developer-guy developer-guy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(attest): custom annotations support developer-guy/cosign
3 participants
@dlorenc @asraa @developer-guy