Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Secret contains a valid Public Key. #1596

Closed
vaikas opened this issue Mar 11, 2022 · 1 comment · Fixed by #1602
Closed

Validate Secret contains a valid Public Key. #1596

vaikas opened this issue Mar 11, 2022 · 1 comment · Fixed by #1602
Labels
enhancement New feature or request

Comments

@vaikas
Copy link
Contributor

vaikas commented Mar 11, 2022

As a follow up to #1595 ensure that the secret being read is a valid public key.

This is just tracking that work.
@vaikas vaikas added the enhancement New feature or request label Mar 11, 2022
This was referenced Mar 11, 2022
Merged
Closed
This was referenced Mar 11, 2022
Closed
Merged
@hectorj2f
Copy link
Contributor

Closing as it was addressed by #1598

vaikas added a commit to vaikas/cosign that referenced this issue Mar 14, 2022
@vaikas
Validate a public key in a secret is valid.
59a06fd 
Fixes: sigstore#1596

secret key contains valid public key.

Signed-off-by: Ville Aikas <[email protected]>
@vaikas vaikas mentioned this issue Mar 14, 2022
Merged
vaikas added a commit that referenced this issue Mar 14, 2022
@vaikas
Validate a public key in a secret is valid. (#1602)
aadaa91 
* Validate a public key in a secret is valid.

Fixes: #1596

secret key contains valid public key.

Signed-off-by: Ville Aikas <[email protected]>

* Remove unused variable.

Signed-off-by: Ville Aikas <[email protected]>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this issue May 6, 2022
@vaikas @mlieberman85
Validate a public key in a secret is valid. (sigstore#1602)
8b3966f 
* Validate a public key in a secret is valid.

Fixes: sigstore#1596

secret key contains valid public key.

Signed-off-by: Ville Aikas <[email protected]>

* Remove unused variable.

Signed-off-by: Ville Aikas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate a public key in a secret is valid. vaikas/cosign
2 participants
@hectorj2f @vaikas