Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The port for the OIDC callback listener cannot be specified #1311

Closed
rgerganov opened this issue Jan 13, 2022 · 1 comment
Closed

The port for the OIDC callback listener cannot be specified #1311

rgerganov opened this issue Jan 13, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@rgerganov
Copy link
Contributor

cosign is starting a callback listener on localhost which receives the code from the OIDC issuer. The problem is that it uses a random free port, see here. So there is no way to know the exact redirect URL in advance for the OIDC dance. This is a problem because some (most?) OIDC issuers require a white list of callback URLs to be configured in advance otherwise they won't work. One example is Auth0 where I can put http://localhost:<port> as callback URL if I know the port number in advance.

So I propose adding a new command line argument (e.g. --oidc-callback-port) which specifies the port number of the callback listener. By default it will be 0 which means a random free port on localhost (current behavior). Let me know if this sounds reasonable and I will start working on PRs for the sigstore library and cosign.

@hectorj2f
Copy link
Contributor

Closing it, as addressed in sigstore/sigstore#353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants