Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx: revise the --upload and add --output-signature flags #1059

Closed
Dentrax opened this issue Nov 16, 2021 · 2 comments · Fixed by #1066
Closed

dx: revise the --upload and add --output-signature flags #1059

Dentrax opened this issue Nov 16, 2021 · 2 comments · Fixed by #1066
Assignees
Labels
enhancement New feature or request

Comments

@Dentrax
Copy link
Member

Dentrax commented Nov 16, 2021

Description

From the discussion we had here with @imjasonh and @developer-guy, dropping the idea here, so we do not forget!

--upload --skip-upload

We currently use the --upload=false flag to decide whether to upload the signature, true by default. Since passing true does not change the current logic, I think it had better to rename this flag something like: --skip-upload.

--output-signature

If we are working with the pull-through cache/mirror repositories, we probably want to skip the upload stage and export the signature to a specified file by defining an --output-signature.

@Dentrax Dentrax added the enhancement New feature or request label Nov 16, 2021
@imjasonh
Copy link
Member

FWIW, --upload=(true|false) sounds just fine to me, I don't think renaming it is worth breaking current users or going through a deprecation and switch-over.

In general I don't think we should feel the need to change cosign's CLI or Go packages just to support the relatively exotic and esoteric use case that kontain.me is shooting for.

@dekkagaijin
Copy link
Member

cc @n3wscott

Dentrax added a commit to Dentrax/cosign that referenced this issue Nov 17, 2021
Fixes sigstore#1059

Signed-off-by: Furkan <[email protected]>
Co-authored-off-by: Batuhan <[email protected]>
dlorenc pushed a commit that referenced this issue Nov 18, 2021
* feat: add output flag for signCmd

Fixes #1059

Signed-off-by: Furkan <[email protected]>
Co-authored-off-by: Batuhan <[email protected]>

* docs: regenerate doc gen

Signed-off-by: Batuhan Apaydın <[email protected]>

Co-authored-by: Batuhan Apaydın <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants