Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sigstore/cosign
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e027cff8992ba435c2ede6e8745e01065ba3aa00
Choose a base ref
..
head repository: sigstore/cosign
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7a87d68dd4101be5b3035e2feb1cd366b654508d
Choose a head ref
Showing with 3 additions and 3 deletions.
  1. +2 −2 pkg/cosign/kubernetes/webhook/validator_test.go
  2. +1 −1 test/e2e_test_cluster_image_policy_with_attestations.sh
4 changes: 2 additions & 2 deletions pkg/cosign/kubernetes/webhook/validator_test.go
Original file line number Diff line number Diff line change
@@ -381,10 +381,10 @@ UoJou2P8sbDxpLiE/v3yLw1/jyOrCPWYHWFXnyyeGlkgSVefG54tNoK7Uw==
want: func() *apis.FieldError {
var errs *apis.FieldError
fe := apis.ErrGeneric("failed policy: cluster-image-policy-keyless", "image").ViaFieldIndex("initContainers", 0)
fe.Details = fmt.Sprintf("%s failed evaluating cue policy for ClusterImagePolicy : string literal not terminated", digest.String())
fe.Details = fmt.Sprintf("%s failed evaluating cue policy for ClusterImagePolicy : failed to compile the cue policy with error: string literal not terminated", digest.String())
errs = errs.Also(fe)
fe2 := apis.ErrGeneric("failed policy: cluster-image-policy-keyless", "image").ViaFieldIndex("containers", 0)
fe2.Details = fmt.Sprintf("%s failed evaluating cue policy for ClusterImagePolicy : string literal not terminated", digest.String())
fe2.Details = fmt.Sprintf("%s failed evaluating cue policy for ClusterImagePolicy : failed to compile the cue policy with error: string literal not terminated", digest.String())
errs = errs.Also(fe2)
return errs
}(),
2 changes: 1 addition & 1 deletion test/e2e_test_cluster_image_policy_with_attestations.sh
Original file line number Diff line number Diff line change
@@ -214,7 +214,7 @@ echo '::endgroup::'
# The CIP policy is the one that should fail now because it doesn't have enough
# attestations
echo '::group:: test job rejection'
expected_error='no matching attestations'
expected_error='failed to evaluate the policy with error: authorityMatches.keylessattMinAttestations'
assert_error ${expected_error}
echo '::endgroup::'