From 96613ae387f6d2d2363c9b88b5c35a9c626b0d15 Mon Sep 17 00:00:00 2001 From: Jason Hall Date: Thu, 21 Jul 2022 06:33:06 -0400 Subject: [PATCH] Remove hack/tools.go (#2080) * Remove hack/tools.go This was a relic of the time when this repo contained the cosigned webhook (now policy-controller in its own repo). These deps weren't included in the cosign CLI, and can just be dropped from the repo. Signed-off-by: Jason Hall * remove update-codegen.sh and verify check Signed-off-by: Jason Hall --- .github/workflows/verify-codegen.yaml | 57 --------------------------- go.mod | 6 +-- go.sum | 8 ---- hack/tools.go | 35 ---------------- hack/update-codegen.sh | 40 ------------------- hack/update-deps.sh | 10 +---- 6 files changed, 3 insertions(+), 153 deletions(-) delete mode 100644 .github/workflows/verify-codegen.yaml delete mode 100644 hack/tools.go delete mode 100755 hack/update-codegen.sh diff --git a/.github/workflows/verify-codegen.yaml b/.github/workflows/verify-codegen.yaml deleted file mode 100644 index 1c4325d30fd..00000000000 --- a/.github/workflows/verify-codegen.yaml +++ /dev/null @@ -1,57 +0,0 @@ -# -# Copyright 2022 The Sigstore Authors. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -name: Codegen - -on: - workflow_dispatch: - push: - branches: ['main', 'release-*'] - pull_request: - -permissions: read-all - -jobs: - verify: - name: Verify codegen - runs-on: ubuntu-latest - - env: - GOPATH: ${{ github.workspace }} - - steps: - - uses: actions/setup-go@84cbf8094393cdc5fe1fe1671ff2647332956b1a - with: - go-version: '1.18' - check-latest: true - - - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b - with: - path: ./src/github.com/${{ github.repository }} - fetch-depth: 0 - - - - shell: bash - working-directory: ./src/github.com/${{ github.repository }} - run: | - ./hack/update-codegen.sh - - # For whatever reason running this makes it not complain... - git status - - - uses: chainguard-dev/actions/nodiff@4ba8d060251254fc0e65500a8d3a90013a22a8d7 # main - with: - path: ./src/github.com/${{ github.repository }} - fixup-command: "./hack/update-codegen.sh" diff --git a/go.mod b/go.mod index a679c541101..f1b1cfdba09 100644 --- a/go.mod +++ b/go.mod @@ -81,10 +81,7 @@ require ( k8s.io/api v0.23.5 k8s.io/apimachinery v0.23.5 k8s.io/client-go v0.23.5 - k8s.io/code-generator v0.23.6 - k8s.io/kube-openapi v0.0.0-20220124234850-424119656bbf k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9 - knative.dev/hack v0.0.0-20220701014203-65c463ac8c98 knative.dev/pkg v0.0.0-20220325200448-1f7514acd0c2 sigs.k8s.io/release-utils v0.6.0 ) @@ -154,7 +151,6 @@ require ( github.com/docker/docker v20.10.17+incompatible // indirect github.com/docker/docker-credential-helpers v0.6.4 // indirect github.com/dustin/go-humanize v1.0.0 // indirect - github.com/emicklei/go-restful v2.9.5+incompatible // indirect github.com/emicklei/proto v1.6.15 // indirect github.com/envoyproxy/go-control-plane v0.10.2-0.20220325020618-49ff273808a1 // indirect github.com/envoyproxy/protoc-gen-validate v0.6.2 // indirect @@ -294,8 +290,8 @@ require ( gopkg.in/natefinch/lumberjack.v2 v2.0.0 // indirect gopkg.in/yaml.v3 v3.0.1 // indirect gotest.tools/v3 v3.1.0 // indirect - k8s.io/gengo v0.0.0-20220307231824-4627b89bbf1b // indirect k8s.io/klog/v2 v2.60.1-0.20220317184644-43cc75f9ae89 // indirect + k8s.io/kube-openapi v0.0.0-20220124234850-424119656bbf // indirect sigs.k8s.io/json v0.0.0-20211208200746-9f7c6b3444d2 // indirect sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect sigs.k8s.io/yaml v1.3.0 // indirect diff --git a/go.sum b/go.sum index 988f75894e7..ab354f0ab2b 100644 --- a/go.sum +++ b/go.sum @@ -723,7 +723,6 @@ github.com/eapache/queue v1.1.0/go.mod h1:6eCeP0CKFpHLu8blIFXhExK/dRa7WDZfr6jVFP github.com/edsrzf/mmap-go v1.0.0/go.mod h1:YO35OhQPt3KJa3ryjFM5Bs14WD66h8eGKpfaBNrHW5M= github.com/elazarl/goproxy v0.0.0-20180725130230-947c36da3153/go.mod h1:/Zj4wYkgs4iZTTu3o/KG3Itv/qCCa8VVMlb3i9OVuzc= github.com/emicklei/go-restful v0.0.0-20170410110728-ff4f55a20633/go.mod h1:otzb+WCGbkyDHkqmQmT5YD2WR4BBwUdeQoFo8l/7tVs= -github.com/emicklei/go-restful v2.9.5+incompatible h1:spTtZBk5DYEvbxMVutUuTyh1Ao2r4iyvLdACqsl/Ljk= github.com/emicklei/go-restful v2.9.5+incompatible/go.mod h1:otzb+WCGbkyDHkqmQmT5YD2WR4BBwUdeQoFo8l/7tVs= github.com/emicklei/proto v1.6.15 h1:XbpwxmuOPrdES97FrSfpyy67SSCV/wBIKXqgJzh6hNw= github.com/emicklei/proto v1.6.15/go.mod h1:rn1FgRS/FANiZdD2djyH7TMA9jdRDcYQ9IEN9yvjX0A= @@ -2894,7 +2893,6 @@ golang.org/x/tools v0.1.2/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk= golang.org/x/tools v0.1.3/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk= golang.org/x/tools v0.1.4/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk= golang.org/x/tools v0.1.5/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk= -golang.org/x/tools v0.1.6-0.20210820212750-d4cc65f0b2ff/go.mod h1:YD9qOF0M9xpSpdWTBbzEl5e/RnCefISl8E5Noe10jFM= golang.org/x/tools v0.1.6/go.mod h1:LGqMHiF4EqQNHR1JncWGqT5BVaXmza+X+BDGol+dOxo= golang.org/x/tools v0.1.7/go.mod h1:LGqMHiF4EqQNHR1JncWGqT5BVaXmza+X+BDGol+dOxo= golang.org/x/tools v0.1.9/go.mod h1:nABZi5QlRsZVlzPpHl034qft6wpY4eDcsTt5AaioBiU= @@ -3261,8 +3259,6 @@ k8s.io/client-go v0.22.5/go.mod h1:cs6yf/61q2T1SdQL5Rdcjg9J1ElXSwbjSrW2vFImM4Y= k8s.io/client-go v0.23.5 h1:zUXHmEuqx0RY4+CsnkOn5l0GU+skkRXKGJrhmE2SLd8= k8s.io/client-go v0.23.5/go.mod h1:flkeinTO1CirYgzMPRWxUCnV0G4Fbu2vLhYCObnt/r4= k8s.io/code-generator v0.19.7/go.mod h1:lwEq3YnLYb/7uVXLorOJfxg+cUu2oihFhHZ0n9NIla0= -k8s.io/code-generator v0.23.6 h1:4J4zL5TU7e96kjGvr5LOFsgR1P9ZU/C6EQeGYcNrFvw= -k8s.io/code-generator v0.23.6/go.mod h1:S0Q1JVA+kSzTI1oUvbKAxZY/DYbA/ZUb4Uknog12ETk= k8s.io/component-base v0.20.1/go.mod h1:guxkoJnNoh8LNrbtiQOlyp2Y2XFCZQmrcg2n/DeYNLk= k8s.io/component-base v0.20.4/go.mod h1:t4p9EdiagbVCJKrQ1RsA5/V4rFQNDfRlevJajlGwgjI= k8s.io/component-base v0.20.6/go.mod h1:6f1MPBAeI+mvuts3sIdtpjljHWBQ2cIy38oBIWMYnrM= @@ -3276,8 +3272,6 @@ k8s.io/gengo v0.0.0-20200413195148-3a45101e95ac/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8 k8s.io/gengo v0.0.0-20200428234225-8167cfdcfc14/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0= k8s.io/gengo v0.0.0-20201113003025-83324d819ded/go.mod h1:FiNAH4ZV3gBg2Kwh89tzAEV2be7d5xI0vBa/VySYy3E= k8s.io/gengo v0.0.0-20210813121822-485abfe95c7c/go.mod h1:FiNAH4ZV3gBg2Kwh89tzAEV2be7d5xI0vBa/VySYy3E= -k8s.io/gengo v0.0.0-20220307231824-4627b89bbf1b h1:vEhKDJESYfeRiaBNmRvO+/12RAo1cFeu6vGm1fBFY34= -k8s.io/gengo v0.0.0-20220307231824-4627b89bbf1b/go.mod h1:FiNAH4ZV3gBg2Kwh89tzAEV2be7d5xI0vBa/VySYy3E= k8s.io/klog/v2 v2.0.0/go.mod h1:PBfzABfn139FHAV07az/IF9Wp1bkk3vpT2XSJ76fSDE= k8s.io/klog/v2 v2.2.0/go.mod h1:Od+F08eJP+W3HUb4pSrPpgp9DGU4GzlpG/TmITuYh/Y= k8s.io/klog/v2 v2.4.0/go.mod h1:Od+F08eJP+W3HUb4pSrPpgp9DGU4GzlpG/TmITuYh/Y= @@ -3300,8 +3294,6 @@ k8s.io/utils v0.0.0-20210930125809-cb0fa318a74b/go.mod h1:jPW/WVKK9YHAvNhRxK0md/ k8s.io/utils v0.0.0-20211116205334-6203023598ed/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA= k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9 h1:HNSDgDCrr/6Ly3WEGKZftiE7IY19Vz2GdbOCyI4qqhc= k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9/go.mod h1:jPW/WVKK9YHAvNhRxK0md/EJ228hCsBRufyofKtW8HA= -knative.dev/hack v0.0.0-20220701014203-65c463ac8c98 h1:kAwcKZOwYU0QCGEwvZrgnLrynFCWnXetwR/+a4W9R70= -knative.dev/hack v0.0.0-20220701014203-65c463ac8c98/go.mod h1:PHt8x8yX5Z9pPquBEfIj0X66f8iWkWfR0S/sarACJrI= knative.dev/pkg v0.0.0-20220325200448-1f7514acd0c2 h1:dJ1YKQ1IvCfxtYqS1dHm18VT153ntHi5uJsFVv7oxfc= knative.dev/pkg v0.0.0-20220325200448-1f7514acd0c2/go.mod h1:5xt0nzCwxvQ2N4w71smY7pYm5nVrQ8qnRsMinSLVpio= mvdan.cc/gofumpt v0.1.1/go.mod h1:yXG1r1WqZVKWbVRtBWKWX9+CxGYfA51nSomhM0woR48= diff --git a/hack/tools.go b/hack/tools.go deleted file mode 100644 index eeb16903dc8..00000000000 --- a/hack/tools.go +++ /dev/null @@ -1,35 +0,0 @@ -//go:build tools -// +build tools - -// Copyright 2022 The Sigstore Authors. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package tools - -// This package imports things required by this repository, to force `go mod` to see them as dependencies -import ( - _ "k8s.io/code-generator" - _ "knative.dev/hack" - - // codegen: hack/generate-knative.sh - _ "knative.dev/pkg/hack" - - _ "k8s.io/code-generator/cmd/client-gen" - _ "k8s.io/code-generator/cmd/deepcopy-gen" - _ "k8s.io/code-generator/cmd/defaulter-gen" - _ "k8s.io/code-generator/cmd/informer-gen" - _ "k8s.io/code-generator/cmd/lister-gen" - _ "k8s.io/kube-openapi/cmd/openapi-gen" - _ "knative.dev/pkg/codegen/cmd/injection-gen" -) diff --git a/hack/update-codegen.sh b/hack/update-codegen.sh deleted file mode 100755 index ec093a9a097..00000000000 --- a/hack/update-codegen.sh +++ /dev/null @@ -1,40 +0,0 @@ -#!/usr/bin/env bash - -# Copyright 2022 The Sigstore Authors -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -set -o errexit -set -o nounset -set -o pipefail - -pushd $(dirname "$0")/.. -# Removed by update-deps -echo === Vendoring scripts -go mod vendor - -source $(dirname $0)/../vendor/knative.dev/hack/codegen-library.sh - -TMP_DIR="$(mktemp -d)" -trap 'rm -rf ${TMP_DIR}' EXIT -# Use the same go mod cache to speed things up. -export GOMODCACHE=${GOPATH}/pkg/mod -export GOPATH=${TMP_DIR} - -TMP_REPO_PATH="${TMP_DIR}/src/github.com/sigstore/cosign" -mkdir -p "$(dirname "${TMP_REPO_PATH}")" && ln -s "${REPO_ROOT_DIR}" "${TMP_REPO_PATH}" - -group "Update deps post-codegen" - -# Make sure our dependencies are up-to-date -${REPO_ROOT_DIR}/hack/update-deps.sh diff --git a/hack/update-deps.sh b/hack/update-deps.sh index 5f3105ca3a1..a5eb656d1d5 100755 --- a/hack/update-deps.sh +++ b/hack/update-deps.sh @@ -19,12 +19,6 @@ set -o nounset set -o pipefail pushd $(dirname "$0")/.. -echo === Vendoring scripts -go mod vendor -source $(dirname "$0")/../vendor/knative.dev/hack/library.sh - -go_update_deps "$@" - -echo === Removing vendor/ -rm -rf $REPO_ROOT_DIR/vendor/ +go get ./... +go mod tidy