Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove DB migrations for legacy database schemas #3181

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Remove DB migrations for legacy database schemas #3181

wants to merge 3 commits into from

Conversation

macladson
Copy link
Member

@macladson macladson commented May 16, 2022 •
edited
Loading

Proposed Changes

Remove support for DB migrations that support upgrading from schema's below version 5. This is mostly for cosmetic/code quality reasons as in most circumstances upgrading from versions of Lighthouse this old will almost always require a re-sync.

Additional Info

The minimum supported database schema is now version 5.

@macladson macladson added the ready-for-review The code is ready for review label May 16, 2022
michaelsproul
michaelsproul requested changes May 16, 2022
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, love the red 🔥

I think there are a few more bits and pieces we can remove in the process, happy to merge after that

beacon_node/beacon_chain/src/schema_change.rs Show resolved Hide resolved
beacon_node/beacon_chain/src/schema_change.rs Show resolved Hide resolved
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. code-quality and removed ready-for-review The code is ready for review labels May 16, 2022
@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels May 17, 2022
michaelsproul
michaelsproul approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels May 17, 2022
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 17, 2022
@macladson
Remove DB migrations for legacy database schemas (#3181)
def9bc6 
## Proposed Changes

Remove support for DB migrations that support upgrading from schema's below version 5. This is mostly for cosmetic/code quality reasons as in most circumstances upgrading from versions of Lighthouse this old will almost always require a re-sync.

## Additional Info

The minimum supported database schema is now version 5.
@bors
Copy link

bors bot commented May 17, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Remove DB migrations for legacy database schemas [Merged by Bors] - Remove DB migrations for legacy database schemas May 17, 2022
@bors bors bot closed this May 17, 2022
@macladson macladson deleted the remove-old-migrations branch May 17, 2022 07:27
@ethDreamer ethDreamer mentioned this pull request May 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
code-quality ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macladson @michaelsproul