[Merged by Bors] - Validators endpoint status code #2040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
requested changes
Dec 3, 2020
There was a problem hiding this comment.
I think a block_task is overkill here, this closure is so small we don't need to worry about it blocking the core executor:
.and(warp::path::param::<ValidatorId>().or_else(|_| async {
Err(warp_utils::reject::custom_bad_request(
"Invalid validator ID".to_string(),
))
}))Let me know your thoughts.
paulhauner
added
waiting-on-author
|
Yep, makes sense. Updated. |
realbigsean
added
ready-for-review
|
bors r+ |
paulhauner
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2020
## Issue Addressed Resolves #2035 ## Proposed Changes Update 405's to 400's for failures when we are parsing path params. ## Additional Info Haven't updated the same for non-standard endpoints Co-authored-by: realbigsean <[email protected]>
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #2035
Proposed Changes
Update 405's to 400's for failures when we are parsing path params.
Additional Info
Haven't updated the same for non-standard endpoints