From c8391b0ea2e5e369f0a227d41ae563f9ae26e5e8 Mon Sep 17 00:00:00 2001 From: blacktemplar <blacktemplar@a1.net> Date: Thu, 10 Sep 2020 17:26:48 +0200 Subject: [PATCH 1/2] ignore too early / too late attestations instead of penalizing them --- beacon_node/network/src/beacon_processor/worker.rs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/beacon_node/network/src/beacon_processor/worker.rs b/beacon_node/network/src/beacon_processor/worker.rs index 672e55da0f0..2c0a0c98f66 100644 --- a/beacon_node/network/src/beacon_processor/worker.rs +++ b/beacon_node/network/src/beacon_processor/worker.rs @@ -562,12 +562,18 @@ impl<T: BeaconChainTypes> Worker<T> { * * The peer has published an invalid consensus message, _only_ if we trust our own clock. */ + trace!( + self.log, + "Attestation is not within the last ATTESTATION_PROPAGATION_SLOT_RANGE slots "; + "peer_id" => peer_id.to_string(), + "block" => format!("{}", beacon_block_root), + "type" => format!("{:?}", attestation_type), + ); self.propagate_validation_result( message_id, peer_id.clone(), - MessageAcceptance::Reject, + MessageAcceptance::Ignore, ); - self.penalize_peer(peer_id.clone(), PeerAction::LowToleranceError); } AttnError::InvalidSelectionProof { .. } | AttnError::InvalidSignature => { /* From a139613b6e3bdd33bad8e68700bbaa747c8f7d19 Mon Sep 17 00:00:00 2001 From: blacktemplar <blacktemplar@a1.net> Date: Thu, 10 Sep 2020 17:40:14 +0200 Subject: [PATCH 2/2] fix typo --- beacon_node/network/src/beacon_processor/worker.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beacon_node/network/src/beacon_processor/worker.rs b/beacon_node/network/src/beacon_processor/worker.rs index 2c0a0c98f66..6388962e595 100644 --- a/beacon_node/network/src/beacon_processor/worker.rs +++ b/beacon_node/network/src/beacon_processor/worker.rs @@ -564,7 +564,7 @@ impl<T: BeaconChainTypes> Worker<T> { */ trace!( self.log, - "Attestation is not within the last ATTESTATION_PROPAGATION_SLOT_RANGE slots "; + "Attestation is not within the last ATTESTATION_PROPAGATION_SLOT_RANGE slots"; "peer_id" => peer_id.to_string(), "block" => format!("{}", beacon_block_root), "type" => format!("{:?}", attestation_type),