Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make execution-endpoint required on the CLI #5159

Closed
zhiqiangxu opened this issue Jan 31, 2024 · 5 comments
Closed

Make execution-endpoint required on the CLI #5159

zhiqiangxu opened this issue Jan 31, 2024 · 5 comments
Labels

Comments

@zhiqiangxu
Copy link
Contributor

zhiqiangxu commented Jan 31, 2024

Here's the command to run bn without execution-endpoint:

lighthouse bn --network sepolia  --http --allow-insecure-genesis-sync

Then I see lots of ExecutionLayerMissing errors:

image

Not sure whether it's the expected behaviour? But IMO if user didn't specify the execution-endpoint, these errors should not be shown since assumed.

@chong-he chong-he added the question Further information is requested label Jan 31, 2024
@chong-he
Copy link
Member

--execution-endpoint must be supplied for a beacon to sync; if it is not supplied, the beacon will complain about it because it can't sync

@zhiqiangxu
Copy link
Contributor Author

zhiqiangxu commented Jan 31, 2024

--execution-endpoint must be supplied for a beacon to sync; if it is not supplied, the beacon will complain about it because it can't sync

Well, why not report an error and quit when started if --execution-endpoint must be supplied?

@michaelsproul
Copy link
Member

Well, why not report an error and quit when started if --execution-endpoint must be supplied?

This is leftover from the pre-Merge era when we went from making --execution-endpoint optional, to making it mandatory. We could make the CLI flag .required(true) now that all networks have merged

@michaelsproul michaelsproul changed the title Lots of ExecutionLayerMissing errors when running bn without execution-endpoint Make execution-endpoint required on the CLI Jan 31, 2024
@michaelsproul michaelsproul added UX-and-logs good first issue Good for newcomers and removed question Further information is requested labels Jan 31, 2024
@Parikalp-Bhardwaj
Copy link

Hi @michaelsproul , I was wondering if this issue is still open or if there's been any update on it?

@jimmygchen
Copy link
Member

Completed in #5165 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants