Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ciritical dependency logging #4954

Closed
AgeManning opened this issue Nov 27, 2023 · 5 comments
Closed

Ciritical dependency logging #4954

AgeManning opened this issue Nov 27, 2023 · 5 comments
Labels
help wanted Extra attention is needed Networking

Comments

@AgeManning
Copy link
Member

Description

We currently do not have default (or good) way of viewing some important logs from our dependencies.

Specifically discovery (discv5) and libp2p. Recently, libp2p has upgraded to use the tracing crate. Discv5 already uses tracing.

We currently can intertwine the dependency logs with our current slog output using the -l parameter switch and setting the rust environment variable RUST_LOG. This has worked in the past for debugging but its sub-optimal as the displayed logs are out of order and it needs to be set manually (meaning we don't have logs for past issues or from users).

The ideal situation would be that lighthouse logs both libp2p and discv5 logs to a file by default. We could then retro-actively view past logs to diagnose issues.

Bonus points if we can limit the size of each file and have the log file automatically remove old logs.

@AgeManning AgeManning added help wanted Extra attention is needed Networking labels Nov 27, 2023
@eserilev
Copy link
Collaborator

i'd like to take a stab at this

@AgeManning
Copy link
Member Author

@eserilev - The help would be appreciated 🙏

@AgeManning
Copy link
Member Author

Just a heads up @eserilev - There is this PR, which seems to be a good start. That helps in adding metrics around the logging. We just got to send it to a file now: #4979

@ackintosh
Copy link
Member

Can this issue be closed since #4988 has been merged?

@AgeManning
Copy link
Member Author

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Networking
Projects
None yet
Development

No branches or pull requests

3 participants