Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ValidatorDuty shim #1643

Closed
paulhauner opened this issue Sep 22, 2020 · 1 comment
Closed

Remove ValidatorDuty shim #1643

paulhauner opened this issue Sep 22, 2020 · 1 comment
Labels
A1 code-quality

Comments

@paulhauner
Copy link
Member

Description

In #1569, we refactor the HTTP API. To avoid more refactoring in the VC, we "shim" the new types into the old ones:

https://github.com/sigp/lighthouse/blob/754396836ea1892b0b3ee9558d0beb70742e793c/validator_client/src/validator_duty.rs

We should remove this shim and make the VC pass around types that are more suited to the new HTTP API.

Notes
@paulhauner paulhauner added A1 and removed A2 labels Nov 8, 2020
@paulhauner
Copy link
Member Author

Resolved by #2243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A1 code-quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulhauner