From 41321c128d41e83d56e36dde75c53f6184425eb0 Mon Sep 17 00:00:00 2001 From: Paul Hauner Date: Thu, 28 Jul 2022 05:12:25 +0000 Subject: [PATCH] Downgrade Geth to v1.10.20 in EE integration tests (#3382) ## Issue Addressed NA ## Proposed Changes The execution integration tests have started failing since Geth updated to v1.10.21. More details here: https://github.com/ethereum/go-ethereum/issues/25427#issuecomment-1197552755 This PR pins our version at v1.10.20. ## Additional Info NA --- testing/execution_engine_integration/src/geth.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/testing/execution_engine_integration/src/geth.rs b/testing/execution_engine_integration/src/geth.rs index 8c751ed651..ae5210b2a3 100644 --- a/testing/execution_engine_integration/src/geth.rs +++ b/testing/execution_engine_integration/src/geth.rs @@ -7,7 +7,7 @@ use std::{env, fs::File}; use tempfile::TempDir; use unused_port::unused_tcp_port; -const GETH_BRANCH: &str = "master"; +// const GETH_BRANCH: &str = "master"; const GETH_REPO_URL: &str = "https://github.com/ethereum/go-ethereum"; pub fn build_result(repo_dir: &Path) -> Output { @@ -26,8 +26,13 @@ pub fn build(execution_clients_dir: &Path) { build_utils::clone_repo(execution_clients_dir, GETH_REPO_URL).unwrap(); } + // TODO: this should be set back to the latest release once the following issue is resolved: + // + // - https://github.com/ethereum/go-ethereum/issues/25427 + // // Get the latest tag on the branch - let last_release = build_utils::get_latest_release(&repo_dir, GETH_BRANCH).unwrap(); + // let last_release = build_utils::get_latest_release(&repo_dir, GETH_BRANCH).unwrap(); + let last_release = "v1.10.20"; build_utils::checkout(&repo_dir, dbg!(&last_release)).unwrap(); // Build geth