Optionally notify app of unverifiable enr #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
requested review from
jxs,
ackintosh and
AgeManning
and removed request for
jxs
|
Once we get this down, we can make a new minor release, which will also target a new ENR minor release |
AgeManning
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discv5 is a great library, but to use it with EL some quirks have been needed. The major one being, notifying the app of discovered peers that advertise a socket that doesn't verify against their actual socket.
How a node behaves before it has discovered its WAN reachable socket, is not spec'd out. The go implementation advertises localhost in the ENR, if no WAN reachable socket is set, since it's the least usable address the node can advertise (as opposed to useless no address). This doesn't fit with the rust implementation, which verifies ENRs against their source to mitigate DoS attacks against the advertised address.
Notes & open questions
Adding this event breaks the API. To allow for adding more events in the future without breaking the api, the
non_exhaustiveattribute is added toEvent.Change checklist