Adjust some logs #225
Merged
Adjust some logs #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
changed the title
AgeManning
reviewed
Dec 11, 2023
| warn!("Query id: {:?} timed out", query.id()); | ||
| Poll::Ready(QueryEvent::TimedOut(Box::new(query))) | ||
| } | ||
| QueryPoolState::Timeout(query) => Poll::Ready(QueryEvent::TimedOut(Box::new(query))), |
There was a problem hiding this comment.
Suggested change
| QueryPoolState::Timeout(query) => Poll::Ready(QueryEvent::TimedOut(Box::new(query))), | |
| debug!("Query id: {:?} timed out", query.id()); | |
| QueryPoolState::Timeout(query) => Poll::Ready(QueryEvent::TimedOut(Box::new(query))), |
Users can set the max time for a query. It's useful to know if the results were partial or not. How about downgrading to a debug?
There was a problem hiding this comment.
The reason why I removed it is because a query timeout is on itself an event emited via the callback. Also queries belong to request so I'm not sure the query id on itself is useful info.
Do you still prefer to have this as a debug statement?
AgeManning
approved these changes
Dec 11, 2023
AgeManning
added a commit
that referenced
this pull request
Feb 21, 2024
* Version bump to v0.3.1 (#203) * fix docs (#204) * refactor for removing `Discv5` prefix (#206) * goodbye prefix * adjust docs * fix rpc decoding to reject extra data (#208) * reject extra data * reduce diff * expected_responses remains after challenge has been completed (#210) * Replace `Handler::spawn` with `build_handler()` and `Handler::start()` * Test the handler's states after the handler has been terminated * Remove expected response on handle_auth_message() * Rename variables for readability * Expose local ENR Arc (#214) * Use zero ports in tests (#216) * update dependencies (#219) * Changing port of ReponseBody::Pong to NonZeroU16 (#220) * Change `port` from u16 to NonZeroU16 * Fix tests * Fix test: the PONG port can't be zero * Fix clippy warnings * Update 'enr' dependency (#223) * Add support for concurrent requests to a single peer. (#200) Co-authored-by: ackintosh <[email protected]> Co-authored-by: Diva M <[email protected]> Co-authored-by: Age Manning <[email protected]> * Adjust some logs (#225) * remove log for timed out query. This is always informed in the callback * expand common logs, unify info on startup * adjust auth header log * Update src/service.rs * Appease clippy * Realised I was wrong. Don't need this log, my bad * fmt --------- Co-authored-by: Age Manning <[email protected]> * Version bump to v0.4.0 * make tracing-subscriber a dev dep (#226) * Fix warnings and bump libp2p (#232) * Update session_cache_capacity from usize to NonZeroUsize since the argument of LruCache::new is NonZeroUsize. * Fix rustdoc * cargo fmt * Fix a merging mistake: lost validation in Message::decode --------- Co-authored-by: Age Manning <[email protected]> Co-authored-by: Divma <[email protected]> Co-authored-by: Jack McPherson <[email protected]> Co-authored-by: João Oliveira <[email protected]> Co-authored-by: Milos Stankovic <[email protected]> Co-authored-by: Nick Gheorghita <[email protected]> Co-authored-by: Diva M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust some common logs seen on sigp/lighthouse#4979
Notes & open questions
Change checklist