Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Metric #213

Closed
AgeManning opened this issue Sep 26, 2023 · 2 comments
Closed

Add Error Metric #213

AgeManning opened this issue Sep 26, 2023 · 2 comments

Comments

@AgeManning
Copy link
Member

It would be useful to add a warning and error metric to the global metrics.

This way if an error or warning occurs we increment these counts. Often in Lighthouse, we dont emit logs for discovery and a variety of errors and warnings can go unnoticed.

If we had these in the metrics we could just monitor metrics for discovery to observe if anything is going wrong.
I think it would be good to add the following metrics:

  • Error count
  • Warning count
  • Error Type - Give some string context as to which type of error this is. As the debug logs are not saved and we see a large error/warning count it would be good to provide some context into what these errors are.
@jmcph4
Copy link
Member

jmcph4 commented Sep 26, 2023

Error Type - Give some string context as to which type of error this is. As the debug logs are not saved and we see a large error/warning count it would be good to provide some context into what these errors are.

Is the intent here for this to collect the actual error types themselves (i.e., Vec<ErrorKind>) or maintain counters for each type?

@AgeManning
Copy link
Member Author

Upstream users can build their own as was done in lighthouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants