Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/improve get account transactions #843

Merged
merged 7 commits into from
Dec 1, 2024
Merged

Feat/improve get account transactions #843

merged 7 commits into from
Dec 1, 2024

Conversation

ohager
Copy link
Member

@ohager ohager commented Dec 1, 2024 •
edited
Loading

Trying to improve the getAccountTransactions implementation.

some rough measurements:

Account V2 Non-Indirects V2 Indirects V1 Non-Indirects V1 Indirects
S-GG4B-34Y9-ZXGV-FNTNJ 353 369 753 746
S-9K9L-4CB5-88Y5-F5G4Z 80 817 90 787

using firstIndex=0, lastIndex=100 on sqlite local

the unionAll statement was replaced and it looks like it has some positive effect...350ms vs 750ms

@ohager ohager requested a review from jjos2372 as a code owner December 1, 2024 19:28
@ohager ohager merged commit 442d93e into develop Dec 1, 2024
2 checks passed
@ohager ohager deleted the feat/improve-get-account-transactions branch December 1, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjos2372 jjos2372 Awaiting requested review from jjos2372 jjos2372 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ohager