-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Check mxBean compatibility #1508
Conversation
@asuresh4 this repository requires commits to be signed https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits you also need to add the gpg key to your github account. Also take a look at https://safjan.com/git-sign-previous-commit/ |
133d959
to
eb7570d
Compare
Thanks @laurit , just amended the commit. |
@breedx-splk @laurit thanks for reviewing and merging this. Would it be possible to do a patch release including the fix? We have a customer waiting for this. If that is not a possibility when is the next planned release? Thanks again! |
@asuresh4 I think the next planned release would be on 16 nov. Patch release can be done if needed. It would help if you could provide a sentence for changelog that would describe what this fixes, or describe what failed without this fix. |
@laurit Yes, the underlying issue is the same. Before this fix, we were invoking Specifically, the order in which these methods are invoked here: https://github.com/signalfx/splunk-otel-java/pull/1435/files#diff-02b1f2b3a1bbe74fb65beb4e221e386aef0aef86ccabfca6a9774430035955c2R39 |
* fix: Check mxBean compatibility (#1508) * Prepare 1.29.1 patch release * Fix smoke test collector conf (#1503) --------- Co-authored-by: Akash Suresh <[email protected]>
Check for mxBean compatibility ahead of checking whether Allocated Memory is enabled. This is related to #1435 .