localhost on agent #3732
Merged
localhost on agent #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
localhostonagent
branch
4 times, most recently
from
c509a75 to
34a7c86
Compare
rmfitzpatrick
force-pushed
the
localhostonagent
branch
from
34a7c86 to
04e25a3
Compare
rmfitzpatrick
force-pushed
the
localhostonagent
branch
2 times, most recently
from
fa4375b to
d01ed1a
Compare
hughesjj
approved these changes
Oct 6, 2023
jinja2
reviewed
Oct 6, 2023
atoulme
approved these changes
Oct 6, 2023
|
Our salt module should also be updated: https://github.com/signalfx/splunk-otel-collector/blob/main/deployments/salt/splunk-otel-collector/collector_config.sls#L29 |
rmfitzpatrick
force-pushed
the
localhostonagent
branch
from
e158422 to
b3eccce
Compare
Co-authored-by: Jina Jain <[email protected]>
rmfitzpatrick
force-pushed
the
localhostonagent
branch
from
b3eccce to
d9f9df3
Compare
* Add chef tests for listen interface * Add puppet tests for listen interface * Add salt tests for listen interface
jeffreyc-splunk
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
These changes update the
SPLUNK_LISTEN_INTERFACEenvironment variable to be 127.0.0.1 for the default agent config locations where it was otherwise 0.0.0.0 in all cases. They also update the installers to only forward the env var to the target service if configured by the user.supersedes #3639
Testing:
Updated unit and integration tests.
Documentation:
Updated readmes