Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support splunk.discovery mapping in properties.discovery.yaml #3238

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

rmfitzpatrick
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick commented Jun 9, 2023

These changes introduce a new mapped form for discovery.properties.yaml content:

splunk.discovery:
  extensions:
    observer_type:
      enabled: false
  receivers:
    receiver_type/receiver_name:
      enabled: false
      config:
        field: value

The properties in this form are compatible with the existing --set style ones in the same file* and have a lower sourcing precedence to account for collisions. Invalid properties loaded from the file will be ignored and logged as warnings so as not to interfere with collector startup.

In order to reuse an existing mergeMaps util it was migrated to a new internal package.

@rmfitzpatrick rmfitzpatrick requested review from a team as code owners June 9, 2023 18:51
Copy link
Contributor

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Seems simpler!

@rmfitzpatrick rmfitzpatrick force-pushed the mappeddiscoveryproperties branch from 1cbef71 to 5c5095f Compare June 12, 2023 15:03
@rmfitzpatrick rmfitzpatrick merged commit d2eaf1c into main Jun 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the mappeddiscoveryproperties branch June 12, 2023 17:09
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants