Disable signalfx exporter default translations in clusterReceiver #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change disables signalfx exporter default translations the clusterReceiver deploymentto avoid wasting CPU cycles. Removing of `opencensus.resourcetype` attribute was the only translation applicable to k8s_cluster receiver metrics. After it the attribute was disabled on the receiver side in signalfx#914, the default translations are not needed anymore. This can be a breaking change for Splunk Observability users who use the deprecated `translation_rules` option in signalfx exporter in clusterReceiver. The option has been deprecated for more than half a year, so we should encourage users to not use it anymore.
dmitryax
force-pushed
the
remove-cluster-receiver-translations
branch
from
7b21935 to
6bc1973
Compare
jvoravong
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables signalfx exporter default translations in the clusterReceiver deployment to avoid wasting CPU cycles. Removing of
opencensus.resourcetypeattribute was the only translation applicable to k8s_cluster receiver metrics. After the attribute was disabled on the receiver side in #914, the default translations are not needed anymore.This can be a breaking change for Splunk Observability users who use the deprecated
translation_rulesoption in signalfx exporter in clusterReceiver. The option has been deprecated for more than half a year, so we should encourage users not to use it anymore.