Update PodDisruptionBudgets API version #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoGoat
changed the title
dmitryax
changed the title
|
@dmitryax hi, sorry, any advice on the test that failed? It was the functional tests bit that failed and I wouldn't think this change would affect any changes... Could this be fixed just rerunning the workflow or is there something obvious I'm missing that's at fault? |
|
That test is flaky, sorry |
|
Not a problem, just got me worried there for a second 🙈 |
Sure, thank you! |
|
oh no, functional tests strike again 😢 though it's cri-o this time, not docker |
|
rerunning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #833 PodDisruptionBudget policies fail to create at k8s v1.25+
Description:
Capabilities.KubeVersion.Versionchecks the kube version. If above 1.21,apiVersion: policy/v1is set for PodDisruptionBudget, elseapiVersion: policy/v1beta1.