Update the log level for metric scrape failures of the smartagent/kubernetes-proxy receiver from error to debug #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… agent receivers from error to debug
Co-authored-by: Ryan Fitzpatrick <[email protected]>
jinja2
approved these changes
Jun 27, 2023
Merged
…ernetes-proxy receiver from error to debug when distribution=''
…t into OTL-control-plane-debug # Conflicts: # examples/add-filter-processor/rendered_manifests/daemonset.yaml # examples/add-receiver-creator/rendered_manifests/daemonset.yaml # examples/add-sampler/rendered_manifests/daemonset.yaml # examples/autodetect-istio/rendered_manifests/daemonset.yaml # examples/collector-agent-only/rendered_manifests/daemonset.yaml # examples/collector-all-modes/rendered_manifests/daemonset.yaml # examples/crio-logging/rendered_manifests/daemonset.yaml # examples/default/rendered_manifests/daemonset.yaml # examples/enable-operator-and-auto-instrumentation/rendered_manifests/daemonset.yaml # examples/enabled-pprof-extension/rendered_manifests/daemonset.yaml # examples/fluentd-multiline-logs-java-stack-traces/rendered_manifests/daemonset.yaml # examples/kubernetes-windows-nodes/rendered_manifests/daemonset.yaml # examples/only-metrics-platform/rendered_manifests/daemonset.yaml # examples/only-metrics/rendered_manifests/daemonset.yaml # examples/route-data-through-gateway-deployed-separately/rendered_manifests/daemonset.yaml # examples/use-proxy/rendered_manifests/daemonset.yaml
jvoravong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The default behavior of smart agent receivers based on Prometheus was to log an error when a metric scraping failure occurs. This can result in excessive log noise, especially when dealing with unstable metric source targets. Prometheus native metric collector mechanisms log these failures at the debug level. In the case of our control plane smart agent receivers in this chart, deploying them to a new, untested, or unsupported Kubernetes distribution can generate a significant amount of log error noise. These changes aim to reduce unexpected log noise when deploying to Kubernetes environments that are not directly supported by this chart.
Notes: