Do not mount docker logs path in GKE Autopilot #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path is not needed in GKE Autopilot because it doesn't come with docker engine. This is a preparation to allow native logs collection in Autopilot cluster which is currently not supported, so no need to a changelog entry.
rmfitzpatrick
approved these changes
Jun 27, 2023
jvoravong
approved these changes
Jun 27, 2023
legoGoat
added a commit
to legoGoat/splunk-otel-collector-chart
that referenced
this pull request
Jun 27, 2023
* Do not mount docker logs path in GKE Autopilot (signalfx#831) The path is not needed in GKE Autopilot because it doesn't come with docker engine. This is a preparation to allow native logs collection in Autopilot cluster which is currently not supported, so no need to a changelog entry. * Prepare release 0.80.0 (signalfx#834) * Prepare release 0.80.0 * add newline --------- Co-authored-by: Dmitrii Anoshin <[email protected]> Co-authored-by: Jina Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path is not needed in GKE Autopilot because it doesn't come with docker engine. This is a preparation to allow native logs collection in Autopilot cluster which is currently not supported, so no need for a changelog entry.