Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the OpenTelemetry Operator as a subchart #691

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Add the OpenTelemetry Operator as a subchart #691

merged 4 commits into from
Mar 16, 2023

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented Mar 8, 2023 •
edited
Loading

Description:

  • In this PR I would like to add basic support for this chart to be able to deploy the OpenTelemetry Collector for auto-instrumentation features.
  • This PR is intentionally slim and lacking documentations and tests that will come later.
  • Users will not be able to use this new functionality yet, we have a couple more changes to make for this functionality is ready. We use the operator.enabled configuration value and values.schema.json validation to prevent usage.
  • I had to update our the github action pipelines for a couple different reasons.

Testing:
Code was successfully tested manually. Will be adding automated functional tests later.

@jvoravong jvoravong force-pushed the OTL-1409 branch 5 times, most recently from 6b438b9 to ed6a88b Compare March 9, 2023 14:17
@jvoravong jvoravong marked this pull request as ready for review March 9, 2023 14:28
@jvoravong jvoravong requested review from a team as code owners March 9, 2023 14:28
dmitryax
dmitryax reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. But let's release 0.72.0 before merging this?

helm-charts/splunk-otel-collector/values.yaml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
atoulme
atoulme reviewed Mar 9, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jvoravong jvoravong force-pushed the OTL-1409 branch 2 times, most recently from 82f52f8 to db2c28f Compare March 16, 2023 18:15
@jvoravong jvoravong merged commit 3471875 into signalfx:main Mar 16, 2023
@jvoravong jvoravong deleted the OTL-1409 branch March 16, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@atoulme atoulme atoulme left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvoravong @atoulme @dmitryax