Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to overwrite default SCC with values.yaml #643

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Allow to overwrite default SCC with values.yaml #643

merged 2 commits into from
Jan 25, 2023

Conversation

hvaghani221
Copy link
Contributor

When using openshift distribution, helm chart creates SecurityContextConstraints object, but it's content cannot be modified. With this PR, user can for example add seccompProfiles to the SCC with following config:

securityContextConstraintsOverwrite:
  seccompProfiles:
  - runtime/default

@hvaghani221 hvaghani221 requested review from a team as code owners January 23, 2023 09:16
@hvaghani221 hvaghani221 mentioned this pull request Jan 23, 2023
Merged
dmitryax
dmitryax reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit. Otherwise LGTM

helm-charts/splunk-otel-collector/values.yaml Show resolved Hide resolved
@hvaghani221 hvaghani221 requested a review from dmitryax January 25, 2023 05:05
@dmitryax dmitryax merged commit b1f0bd7 into main Jan 25, 2023
@hvaghani221 hvaghani221 deleted the extra-scc-rules branch January 25, 2023 06:39
@hvaghani221 hvaghani221 mentioned this pull request Jan 31, 2023
Merged
@kumachop2
Copy link

kumachop2 commented May 10, 2023 •
edited
Loading

@hvaghani221 @dmitryax Please do let me know securityContextConstraintsOverwrite: applicable for AKS as well ? Would like to define allowedHostPaths & hostPorts in order to fix Azure defender issues. Our Kubernetes version is 1.25+.

Thanks much for your timely response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@rmfitzpatrick rmfitzpatrick Awaiting requested review from rmfitzpatrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hvaghani221 @kumachop2 @dmitryax @rmfitzpatrick