Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added acl to journald logs #639

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Added acl to journald logs #639

merged 1 commit into from
Jan 20, 2023

Conversation

hvaghani221
Copy link
Contributor

@hvaghani221 hvaghani221 commented Jan 20, 2023 •
edited
Loading

The Init container was not setting required ACLs to journald directory when running as non-root users.
I made 2 changes in the init container:

  • Set ACLs to journald log directory if journald logs collection is enabled
  • Set default mask value to all log directories

@hvaghani221 hvaghani221 requested review from a team as code owners January 20, 2023 04:58
@hvaghani221 hvaghani221 changed the title added acl to journald logs added acl to journald log directory Jan 20, 2023
@hvaghani221 hvaghani221 changed the title added acl to journald log directory Added acl to journald logs Jan 20, 2023
@hvaghani221 hvaghani221 force-pushed the acl_for_journald_logs branch from f8d4767 to 9b92cc6 Compare January 20, 2023 05:03
@dmitryax dmitryax merged commit b672a39 into main Jan 20, 2023
@hvaghani221 hvaghani221 deleted the acl_for_journald_logs branch January 20, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvaghani221 @dmitryax