Support pushing span/trace through to splunk HEC #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Jan 17, 2023
atoulme
reviewed
Jan 17, 2023
|
Thank you for the contribution, we appreciate it. |
atoulme
reviewed
Jan 17, 2023
helm-charts/splunk-otel-collector/templates/config/_otel-collector.tpl
Outdated
Show resolved
Hide resolved
atoulme
reviewed
Jan 17, 2023
helm-charts/splunk-otel-collector/templates/config/_otel-collector.tpl
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Jan 20, 2023
Comment on lines
+200
to
+206
| exporters: | ||
| {{- if (eq (include "splunk-otel-collector.o11yTracesEnabled" .) "true") }} | ||
| - sapm | ||
| {{- end }} | ||
| {{- if (eq (include "splunk-otel-collector.platformTracesEnabled" .) "true") }} | ||
| - splunk_hec/platform_traces | ||
| {{- end }} |
There was a problem hiding this comment.
Similar changes need to be done in the agent config. The gateway is not enabled by default
There was a problem hiding this comment.
good spot! I updated the agent config (we switched to running in gateway mode hence not spotting it)
|
Thanks, @mr-miles. There is no reason to not enable tracing for Splunk Platform destination |
|
@dmitryax good spot! I updated the agent config (we were running in
gateway mode hence not spotting it)
…On Fri, Jan 20, 2023 at 7:39 AM Dmitrii Anoshin ***@***.***> wrote:
Thanks, @mr-miles <https://github.com/mr-miles>. There is no reason to
not enable tracing for Splunk Platform destination
—
Reply to this email directly, view it on GitHub
<#629 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQD4HQROVA7NQKEP3RBVLWTI6J3ANCNFSM6AAAAAATXDFOL4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to export spans to our splunk setup from the gateway but the way the chart is currently set up made it difficult to get all the pieces to match up (particularly port declarations across deployment/service/pods) without manually patching each one of them.
So this PR adds tracesIndex/tracesEnabled alongside metricsIndex/metricsEnabled etc so the traces are exported as expected.
Chart is working well in our environment.